What a mess!

by Michael McClenaghan 2005-07-03

I've been busting my butt this morning trying to get some headway on the Pick'Em conversion to DNN 3.x.  After a number of problems with missing SqlDataProviders (switched to Dal Builder Pro from DNNJungle to fix it), source control blunders (using GotDotNet sucks!) and getting ready for a new little brat (hence the animated image), I think that I've finally got it to a point where I'm damn close to getting some good testing.  Luckily, the CFL season is upon us, so I should be able to get some testing in the next few weeks.

One glaring problem that I'll have as I finish up the coding is cleaning up the sprocs.  I don't think that I've ever cleaned it out since the original testing of Pick'Em v1.  After switching between a couple of different code generators and then adding my own goodies, my SQL Server is quite a mess!  Here's what I've found:

In SqlDataProvider but not in SqlServer

  • PickEmCountAll
  • PickEmGetAll
  • PickEmDeleteAll
  • PickEmGamesCountAll
  • PickEmGamesGetAll
  • PickEmGamesDeleteAll
  • PickEmPicksCountAll
  • PickEmPicksGetAll
  • PickEmPicksDeleteAll
  • PickEmPicksByPickEmUsers
  • PickEmUsersCountAll
  • PickEmUsersGetAll
  • PickEmUsersDeleteAll
  • PickEmWeeksCountAll
  • PickEmWeeksGetAll
  • PickEmWeeksDeleteAll

Obviously, I'm not a big fan of the CountAll, GetAll or DeleteAll methods.  The PickEmPicksByPickEmUsers didn't come up either.  But, believe it or not, this is the short list!  On to the next one.

In SqlServer but not in SqlDataProvider

  • PickEmGamesDeleteByWeek
  • PickEmGamesGetByCurrentWeek
  • PickEmGamesGetByModules
  • PickEmGamesGetByPickEmWeeks
  • PickEmGamesGetScoresByPickEmWeeks
  • PickEmGamesList
  • PickEmGetByModules
  • PickEmList
  • PickEmPicksGetByModules
  • PickEmPicksGetByPickEmGames
  • PickEmPicksGetByUsers
  • PickEmPicksGetByUsersAndWeeks
  • PickEmPicksList
  • PickEmReportsGetByUsers
  • PickEmScoresUpdate
  • PickEmTeamsAdd
  • PickEmTeamsDelete
  • PickEmTeamsGet
  • PickEmTeamsGetByModules
  • PickEmTeamsList
  • PickEmTeamsUpdate
  • PickEmUsersGetByModules
  • PickEmUsersGetByUsers
  • PickEmUsersList
  • PickEmWeeksDeleteByModule
  • PickEmWeeksGetByModules
  • PickEmWeeksGetByName
  • PickEmWeeksList

Most of these are caused by a) updates to the ERD that removed ModuleId from most of the tables, b) changes in code generation from DNNJungle to DAL Builder Pro and c) I don't even have a freakin' Teams table!  How old are the Team sprocs'!

Anyways, to be a nice module developer, I suppose that I'll need to write a proper sql file to be deployed with Pick'Em that deletes all of these unneeded sprocs.  What a pain!

 

blog comments powered by Disqus